[gs-bugs] [Bug 698375] - MuPDF - A possible fix for bug 697795 and 698067

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698375

Bug ID: 698375
Summary: A possible fix for bug 697795 and 698067
Product: MuPDF
Version: master
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P4
Component: mupdf
Assignee: mupdf-***@artifex.com
Reporter: ***@gmail.com
QA Contact: gs-***@ghostscript.com
Word Size: ---

The above referenced bugs are both caused by a wrong implicit type-cast in
source/pdf/pdf-write.c (mupdf 1.11)
This wrong type-cast is evident for Windows-32 bit, whilst is harmless for
other platforms/architectures.

The following change in pdf-write.c

from:
static void writexrefstream(fz_context *ctx, pdf_document *doc, pdf_write_state
*opts, int from, int to, int first, int main_xref_offset, int startxref)

to:
static void writexrefstream(fz_context *ctx, pdf_document *doc, pdf_write_state
*opts, int from, int to, int first, int main_xref_offset, fz_off_t startxref)

fixes the bugs. (tested on Windows 32/64, Linux 32/64, MacOS)

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698375

Ardo <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |697795, 698067

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698375

Robin Watts <***@artifex.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@artifex.com
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED

--- Comment #1 from Robin Watts <***@artifex.com> ---
This was fixed as a side effect of:

commit f595e889b91a674eb94db7ca4d832da54f5194cd
Author: Tor Andersson <***@artifex.com>
Date: Thu Aug 17 15:01:09 2017 +0200

Use int64_t for public file API offsets.

Don't mess with conditional compilation with LARGEFILE -- always expose
64-bit file offsets in our public API.

Thanks for the report and the analysis.

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698375
Bug 698375 depends on bug 697795, which changed state.

Bug 697795 Summary: pdf_save_document : Regression in 1.11 ?
http://bugs.ghostscript.com/show_bug.cgi?id=697795

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698375
Bug 698375 depends on bug 698067, which changed state.

Bug 698067 Summary: wrong startxref after incremental save with xref streams
http://bugs.ghostscript.com/show_bug.cgi?id=698067

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED