[gs-bugs] [Bug 698780] - Ghostscript - check_source.py fails to run on mac osx

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698780

Bug ID: 698780
Summary: check_source.py fails to run on mac osx
Product: Ghostscript
Version: master
Hardware: Macintosh
OS: MacOS X
Status: UNCONFIRMED
Severity: normal
Priority: P4
Component: Test Framework
Assignee: ***@artifex.com
Reporter: ***@ultrasaurus.com
QA Contact: gs-***@ghostscript.com
Word Size: ---

following instructions for running tests here:
https://ghostscript.com/doc/8.54/Testing.htm

found this issue on 9.22, reproduced on master

Steps to reproduce:

python toolbin/tests/check_source.py
ERROR: Could not open config file 'toolbin/tests/testing.cfg'.
Traceback (most recent call last):
File "toolbin/tests/check_source.py", line 149, in <module>
gsRunTestsMain(addTests)
File "/Users/sallen/src/ghostpdl/toolbin/tests/gstestutils.py", line 194, in
gsRunTestsMain
addTests(suite, **args)
TypeError: addTests() takes exactly 2 arguments (1 given)

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698780

--- Comment #1 from Ken Sharp <***@artifex.com> ---
Well, the source tree the file is trying to use predates the last
re-organisation, so its really not going to work on any OS.

(for internal discussion) I suggest we simply remove it, unless someone wants
to take on the task of maintaining it. We clearly haven't used it for a long
time.

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698780

Chris Liddell (chrisl) <***@artifex.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@artifex.com

--- Comment #2 from Chris Liddell (chrisl) <***@artifex.com> ---
I'd also add that trying to use documentation from version 8.54 to test version
9.22 is not the wisest course. You might note that "Testing.htm" does not exist
in the 9.22 documentation.......

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698780

--- Comment #3 from Sarah Allen <***@ultrasaurus.com> ---
oh, sorry, I didn't see the version number in the doc, though the tests do seem
to work in master. If I copy the example to create 'testing.cfg' then I can
run the tests:

$ cd toolbin/tests
$ mv testing.cfg.example testing.cfg
$ cd ../..
$ python toolbin/tests/check_source.py
......
----------------------------------------------------------------------
Ran 6 tests in 0.199s

OK

[b***@artifex.com]

http://bugs.ghostscript.com/show_bug.cgi?id=698780

Chris Liddell (chrisl) <***@artifex.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Chris Liddell (chrisl) <***@artifex.com> ---
I've removed the script and config file, since it no longer constitutes part of
our testing process.